Remove fallbacks for unsupported Node versions (brianc#1304) (brianc#1313)

* Add client connectionString tests (brianc#1310)

* Remove redundant tests

* Add client connectionString test

Add test to ensure { connectionString } is respected as an argument to the client constructor

* Add test for connection string property

Also fixed some legacy require statements.

* Normalize native error properties

Map native error properties to the same property names we use for errors from the JS driver.

Fixes brianc#972
Fixes brianc#938

Author: brianc

lib/native/query.js

@@ -51,13 +51,29 @@ NativeQuery.prototype.promise = function() {
   return this._promise;
 };
 
+var errorFieldMap = {
+  'sqlState': 'code',
+  'statementPosition': 'position',
+  'messagePrimary': 'message',
+  'context': 'where',
+  'schemaName': 'schema',
+  'tableName': 'table',
+  'columnName': 'column',
+  'dataTypeName': 'dataType',
+  'constraintName': 'constraint',
+  'sourceFile': 'file',
+  'sourceLine': 'line',
+  'sourceFunction': 'routine',
+};
+
 NativeQuery.prototype.handleError = function(err) {
   var self = this;
   //copy pq error fields into the error object
   var fields = self.native.pq.resultErrorFields();
   if(fields) {
     for(var key in fields) {
-      err[key] = fields[key];
+      var normalizedFieldName = errorFieldMap[key] || key;
+      err[normalizedFieldName] = fields[key];
     }
   }
   if(self.callback) {

lib/pool-factory.js

@@ -3,7 +3,6 @@ var util = require('util');
 var Pool = require('pg-pool');
 
 module.exports = function(Client) {
-
   var BoundPool = function(options) {
     var config = { Client: Client };
     for (var key in options) {

test/integration/connection-pool/double-connection-tests.js

@@ -1,2 +1,2 @@
-var helper = require(__dirname + "/test-helper")
+var helper = require("./test-helper")
 helper.testPoolSize(2);

test/integration/connection-pool/ending-empty-pool-tests.js

@@ -1,4 +1,4 @@
-var helper = require(__dirname + '/test-helper')
+var helper = require('./test-helper')
 
 var called = false;
 test('disconnects', function() {

test/integration/connection-pool/ending-pool-tests.js

@@ -1,6 +1,7 @@
-var helper = require(__dirname + '/test-helper')
+var helper = require('./test-helper')
 
 var called = false;
+
 test('disconnects', function() {
   var sink = new helper.Sink(4, function() {
     called = true;

test/integration/connection-pool/error-tests.js

@@ -1,5 +1,5 @@
-var helper = require(__dirname + "/../test-helper");
-var pg = require(__dirname + "/../../../lib");
+var helper = require("../test-helper");
+var pg = require("../../../lib");
 
 //first make pool hold 2 clients
 pg.defaults.poolSize = 2;

test/integration/connection-pool/max-connection-tests.js

@@ -1,2 +1,2 @@
-var helper = require(__dirname + "/test-helper")
+var helper = require("./test-helper")
 helper.testPoolSize(40);

test/integration/connection-pool/native-instance-tests.js

@@ -1,4 +1,4 @@
-var helper = require(__dirname + "/../test-helper")
+var helper = require("./../test-helper")
 var pg = helper.pg
 var native = helper.args.native
 

test/integration/connection-pool/optional-config-tests.js

@@ -1,4 +1,4 @@
-var helper = require(__dirname + '/test-helper');
+var helper = require('./test-helper');
 
 //setup defaults
 helper.pg.defaults.user = helper.args.user;

test/integration/connection-pool/single-connection-tests.js

@@ -1,2 +1,2 @@
-var helper = require(__dirname + "/test-helper")
+var helper = require("./test-helper")
 helper.testPoolSize(1);

test/integration/connection-pool/single-pool-on-object-config-tests.js

@@ -1,5 +1,5 @@
-var helper = require(__dirname + "/../test-helper");
-var pg = require(__dirname + "/../../../lib");
+var helper = require("../test-helper");
+var pg = require("../../../lib");
 
 pg.connect(helper.config, assert.success(function(client, done) {
     assert.equal(Object.keys(pg._pools).length, 1);

test/integration/connection-pool/waiting-connection-tests.js

@@ -1,2 +1,2 @@
-var helper = require(__dirname + "/test-helper")
+var helper = require("./test-helper")
 helper.testPoolSize(200);

test/native/native-vs-js-error-tests.js

@@ -0,0 +1,20 @@
+var assert = require('assert')
+var Client = require('../../lib/client');
+var NativeClient = require('../../lib/native');
+
+var client = new Client();
+var nativeClient = new NativeClient();
+
+client.connect();
+nativeClient.connect((err) => {
+  client.query('SELECT alsdkfj', (err) => {
+    client.end();
+
+    nativeClient.query('SELECT lkdasjfasd', (nativeErr) => {
+      for(var key in nativeErr) {
+        assert.equal(err[key], nativeErr[key], `Expected err.${key} to equal nativeErr.${key}`)
+      }
+      nativeClient.end();
+    });
+  });
+});

test/unit/client/configuration-tests.js

@@ -59,6 +59,17 @@ test('client settings', function() {
 
 test('initializing from a config string', function() {
 
+  test('uses connectionString property', function () {
+    var client = new Client({
+      connectionString: 'postgres://brian:pass@host1:333/databasename'
+    })
+    assert.equal(client.user, 'brian');
+    assert.equal(client.password, "pass");
+    assert.equal(client.host, "host1");
+    assert.equal(client.port, 333);
+    assert.equal(client.database, "databasename");
+  })
+
   test('uses the correct values from the config string', function() {
     var client = new Client("postgres://brian:pass@host1:333/databasename")
     assert.equal(client.user, 'brian');