Skip to content

[PLT-0]: remove mypy from dependencies #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

[PLT-0]: remove mypy from dependencies #1968

merged 2 commits into from
Apr 16, 2025

Conversation

mrobers1982
Copy link
Contributor

@mrobers1982 mrobers1982 commented Apr 15, 2025 •
edited
Loading

Description

mypy should only be a development dependency.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@mrobers1982 mrobers1982 requested a review from a team as a code owner April 15, 2025 20:24
@mrobers1982 mrobers1982 force-pushed the mrobers1982/PLT_0_remove_mypy branch from 5d6b31d to d85e7f6 Compare April 15, 2025 20:38
paulnoirel
paulnoirel approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@paulnoirel paulnoirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulnoirel paulnoirel merged commit b0aace2 into develop Apr 16, 2025
22 of 26 checks passed
@paulnoirel paulnoirel deleted the mrobers1982/PLT_0_remove_mypy branch April 16, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulnoirel paulnoirel paulnoirel approved these changes

@Jmsa Jmsa Awaiting requested review from Jmsa Jmsa is a code owner automatically assigned from Labelbox/engineers

@manastalukdar manastalukdar Awaiting requested review from manastalukdar manastalukdar is a code owner automatically assigned from Labelbox/engineers

@chunpong chunpong Awaiting requested review from chunpong chunpong is a code owner automatically assigned from Labelbox/engineers

@KahvehS KahvehS Awaiting requested review from KahvehS KahvehS is a code owner automatically assigned from Labelbox/engineers

@dsinha244 dsinha244 Awaiting requested review from dsinha244 dsinha244 is a code owner automatically assigned from Labelbox/engineers

@ArjunNargolwala385 ArjunNargolwala385 Awaiting requested review from ArjunNargolwala385 ArjunNargolwala385 is a code owner automatically assigned from Labelbox/engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrobers1982 @paulnoirel