Skip to content

Commit b17d725

Browse files
committed
change the properties prefix to "javaoperatorsdk"
1 parent 2ef6c8f commit b17d725

File tree

5 files changed

+20
-23
lines changed

5 files changed

+20
-23
lines changed
Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import java.util.Optional;
44

5-
public class OperatorProperties {
5+
public class KubernetesClientProperties {
66

77
private boolean openshift = false;
88
private String username;
@@ -14,7 +14,7 @@ public boolean isOpenshift() {
1414
return openshift;
1515
}
1616

17-
public OperatorProperties setOpenshift(boolean openshift) {
17+
public KubernetesClientProperties setOpenshift(boolean openshift) {
1818
this.openshift = openshift;
1919
return this;
2020
}
@@ -23,7 +23,7 @@ public Optional<String> getUsername() {
2323
return Optional.ofNullable(username);
2424
}
2525

26-
public OperatorProperties setUsername(String username) {
26+
public KubernetesClientProperties setUsername(String username) {
2727
this.username = username;
2828
return this;
2929
}
@@ -32,7 +32,7 @@ public Optional<String> getPassword() {
3232
return Optional.ofNullable(password);
3333
}
3434

35-
public OperatorProperties setPassword(String password) {
35+
public KubernetesClientProperties setPassword(String password) {
3636
this.password = password;
3737
return this;
3838
}
@@ -41,7 +41,7 @@ public Optional<String> getMasterUrl() {
4141
return Optional.ofNullable(masterUrl);
4242
}
4343

44-
public OperatorProperties setMasterUrl(String masterUrl) {
44+
public KubernetesClientProperties setMasterUrl(String masterUrl) {
4545
this.masterUrl = masterUrl;
4646
return this;
4747
}
@@ -50,7 +50,8 @@ public boolean isTrustSelfSignedCertificates() {
5050
return trustSelfSignedCertificates;
5151
}
5252

53-
public OperatorProperties setTrustSelfSignedCertificates(boolean trustSelfSignedCertificates) {
53+
public KubernetesClientProperties setTrustSelfSignedCertificates(
54+
boolean trustSelfSignedCertificates) {
5455
this.trustSelfSignedCertificates = trustSelfSignedCertificates;
5556
return this;
5657
}

operator-framework-spring-boot-starter/src/main/java/io/javaoperatorsdk/operator/springboot/starter/OperatorAutoConfiguration.java

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,16 @@
1717
import java.util.Optional;
1818
import java.util.Set;
1919
import java.util.concurrent.ConcurrentHashMap;
20-
import org.slf4j.Logger;
21-
import org.slf4j.LoggerFactory;
2220
import org.springframework.beans.factory.annotation.Autowired;
2321
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2422
import org.springframework.boot.context.properties.EnableConfigurationProperties;
2523
import org.springframework.context.annotation.Bean;
2624
import org.springframework.context.annotation.Configuration;
2725

2826
@Configuration
29-
@EnableConfigurationProperties({ConfigurationProperties.class})
27+
@EnableConfigurationProperties({OperatorConfigurationProperties.class})
3028
public class OperatorAutoConfiguration implements ConfigurationService {
31-
private static final Logger log = LoggerFactory.getLogger(OperatorAutoConfiguration.class);
32-
@Autowired private ConfigurationProperties configuration;
29+
@Autowired private OperatorConfigurationProperties configuration;
3330
private final Map<String, ControllerConfiguration> controllers = new ConcurrentHashMap<>();
3431

3532
@Bean
@@ -55,15 +52,13 @@ public Config getClientConfiguration() {
5552
@Bean
5653
@ConditionalOnMissingBean(Operator.class)
5754
public Operator operator(
58-
KubernetesClient kubernetesClient,
59-
ConfigurationProperties config,
60-
List<ResourceController> resourceControllers) {
55+
KubernetesClient kubernetesClient, List<ResourceController<?>> resourceControllers) {
6156
Operator operator = new Operator(kubernetesClient, this);
6257
resourceControllers.forEach(r -> operator.register(processController(r)));
6358
return operator;
6459
}
6560

66-
private ResourceController processController(ResourceController controller) {
61+
private ResourceController<?> processController(ResourceController<?> controller) {
6762
final var controllerPropertiesMap = configuration.getControllers();
6863
var controllerProps = controllerPropertiesMap.get(controller.getName());
6964
final var cfg = new ConfigurationWrapper(controller, controllerProps);
Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,19 @@
22

33
import java.util.Collections;
44
import java.util.Map;
5+
import org.springframework.boot.context.properties.ConfigurationProperties;
56

6-
@org.springframework.boot.context.properties.ConfigurationProperties(prefix = "io.javaoperatorsdk")
7-
public class ConfigurationProperties {
8-
private OperatorProperties client = new OperatorProperties();
7+
@ConfigurationProperties(prefix = "javaoperatorsdk")
8+
public class OperatorConfigurationProperties {
9+
10+
private KubernetesClientProperties client = new KubernetesClientProperties();
911
private Map<String, ControllerProperties> controllers = Collections.emptyMap();
1012

11-
// todo: figure out how to be able to use `.kubernetes.client` as prefix
12-
public OperatorProperties getClient() {
13+
public KubernetesClientProperties getClient() {
1314
return client;
1415
}
1516

16-
public void setClient(OperatorProperties client) {
17+
public void setClient(KubernetesClientProperties client) {
1718
this.client = client;
1819
}
1920

operator-framework-spring-boot-starter/src/test/java/io/javaoperatorsdk/operator/springboot/starter/AutoConfigurationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
@SpringBootTest
2121
public class AutoConfigurationTest {
2222

23-
@Autowired private ConfigurationProperties config;
23+
@Autowired private OperatorConfigurationProperties config;
2424

2525
@MockBean private Operator operator;
2626

operator-framework-spring-boot-starter/src/test/resources/application.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
io.javaoperatorsdk:
1+
javaoperatorsdk:
22
client:
33
username: user
44
password: password

0 commit comments

Comments
 (0)