Only define libssp if our CSL intsall actually has it
#58175
Merged
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some CSL installs (such as those from `USE_BINARYBUILDER=0` builds) do not have a `libssp`, because their GCC was built without stack smash protection, or it was statically linked. This allows our CSL_jll to adapt to that, avoiding issues like those reported in [0]. [0]: #58173
staticfloat
added a commit
to JuliaCI/julia-buildkite
that referenced
this pull request
Apr 22, 2025
Testing from-source build for JuliaLang/julia#58175
|
Under test here: JuliaCI/julia-buildkite#443 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CSL installs (such as those from
USE_BINARYBUILDER=0builds) do not have alibssp, because their GCC was built without stack smash protection, or it was statically linked. This allows our CSL_jll to adapt to that, avoiding issues like those reported in 0.This should fix #58173