Skip to content

Commit 2398ce9

Browse files
author
Mano Marks
authored
Merge pull request docker#313 from Pistulls/master
Updating node&npm + readme instructions & fixing general issues
2 parents d4e19a1 + 7cbb087 commit 2398ce9

File tree

6 files changed

+625
-8
lines changed

6 files changed

+625
-8
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
node_modules
2+
.vscode

developer-tools/nodejs-debugging/VSCode-README.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ We've created a simple application which includes an error. You can see the app
2323
Let's take a look at the `Dockerfile`:
2424

2525
```
26-
FROM node:5.11.0-slim
26+
FROM node:8.2.1
2727
2828
WORKDIR /code
2929
@@ -48,7 +48,7 @@ version: "3"
4848
services:
4949
web:
5050
build: .
51-
command: nodemon --debug=5858
51+
command: nodemon --inspect=0.0.0.0:5858
5252
volumes:
5353
- .:/code
5454
ports:
@@ -80,7 +80,7 @@ Attaching to nodeexample_web_1
8080
web_1 | [nodemon] 1.9.2
8181
web_1 | [nodemon] to restart at any time, enter `rs`
8282
web_1 | [nodemon] watching: *.*
83-
web_1 | [nodemon] starting `node --debug=5858 app.js`
83+
web_1 | [nodemon] starting `node --inspect=0.0.0.0:5858 app.js`
8484
web_1 | Debugger listening on port 5858
8585
web_1 | HTTP server listening on port 80
8686
```
@@ -115,8 +115,8 @@ A JSON file will be created and displayed. Replace its contents with the followi
115115
"address": "localhost",
116116
"restart": true,
117117
"sourceMaps": false,
118-
"outDir": null,
119-
"localRoot": "${workspaceRoot}",
118+
"outFiles": [],
119+
"localRoot": "${workspaceRoot}/app",
120120
"remoteRoot": "/code"
121121
}
122122
]

developer-tools/nodejs-debugging/app/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:5.11.0-slim
1+
FROM node:8.2.1
22

33
WORKDIR /code
44

developer-tools/nodejs-debugging/app/app.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
var express = require('express');
2-
var expressHandlebars = require('express-handlebars');
2+
var expressHandlebars = require('express-handlebars');
33
var http = require('http');
44

55
var PORT = 8000;

developer-tools/nodejs-debugging/app/docker-compose.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version: "2"
33
services:
44
web:
55
build: .
6-
command: nodemon --debug=5858
6+
command: nodemon --inspect=5858
77
volumes:
88
- .:/code
99
ports:

0 commit comments

Comments
 (0)