Fixes BroadleafCommerce#1274 - Change the ordering of when extension points in the admin abstract controller are invoked for main actions, enhance some docs

Author: phillipuniverse

admin/broadleaf-open-admin-platform/src/main/java/org/broadleafcommerce/openadmin/web/controller/entity/AdminBasicEntityController.java

@@ -144,14 +144,14 @@ public String viewEntityList(HttpServletRequest request, HttpServletResponse res
         ListGrid listGrid = formService.buildMainListGrid(drs, cmd, sectionKey, crumbs);
         List<EntityFormAction> mainActions = new ArrayList<EntityFormAction>();
         addAddActionIfAllowed(sectionClassName, cmd, mainActions);
+        extensionManager.getProxy().addAdditionalMainActions(sectionClassName, mainActions);
+        extensionManager.getProxy().modifyMainActions(cmd, mainActions);
 
         Field firstField = listGrid.getHeaderFields().iterator().next();
         if (requestParams.containsKey(firstField.getName())) {
             model.addAttribute("mainSearchTerm", requestParams.get(firstField.getName()).get(0));
         }
 
-        extensionManager.getProxy().addAdditionalMainActions(sectionClassName, mainActions);
-        
         // If this came from a delete save, we'll have a headerFlash request parameter to take care of
         if (requestParams.containsKey("headerFlash")) {
             model.addAttribute("headerFlash", requestParams.get("headerFlash").get(0));
@@ -181,7 +181,6 @@ protected void addAddActionIfAllowed(String sectionClassName, ClassMetadata cmd,
         }
 
         mainEntityActionsExtensionManager.getProxy().modifyMainActions(cmd, mainActions);
-        extensionManager.getProxy().modifyMainActions(cmd, mainActions);
     }
 
     protected boolean isAddActionAllowed(String sectionClassName, ClassMetadata cmd) {

admin/broadleaf-open-admin-platform/src/main/java/org/broadleafcommerce/openadmin/web/service/FormBuilderExtensionHandler.java

@@ -116,8 +116,13 @@ public interface FormBuilderExtensionHandler extends ExtensionHandler {
     public ExtensionResultStatusType modifyListGridRecord(String className, ListGridRecord record, Entity entity);
 
     /**
+     * <p>
      * Provides a hook to add additional actions to all entity forms.
      * 
+     * <p>
+     * For order of operation purposes, this is the last thing that is run when building an entity form, which means
+     * that it occurs after {@link #modifyDetailEntityForm(EntityForm)}.
+     * 
      * @param entityForm
      * @return whether or not it was handled
      */