Skip to content

Commit 106b2a5

Browse files
author
jefffischer
committed
BroadleafCommerce#1239 - Make sure CartStateFilter is executed once per request
1 parent 1438802 commit 106b2a5

File tree

1 file changed

+4
-5
lines changed
  • core/broadleaf-framework-web/src/main/java/org/broadleafcommerce/core/web/order/security

1 file changed

+4
-5
lines changed

core/broadleaf-framework-web/src/main/java/org/broadleafcommerce/core/web/order/security/CartStateFilter.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
import org.springframework.security.web.util.RequestMatcher;
3333
import org.springframework.stereotype.Component;
3434
import org.springframework.web.context.request.ServletWebRequest;
35-
import org.springframework.web.filter.GenericFilterBean;
35+
import org.springframework.web.filter.OncePerRequestFilter;
3636

3737
import java.io.IOException;
3838
import java.util.List;
@@ -41,7 +41,6 @@
4141
import javax.servlet.FilterChain;
4242
import javax.servlet.ServletException;
4343
import javax.servlet.ServletRequest;
44-
import javax.servlet.ServletResponse;
4544
import javax.servlet.http.HttpServletRequest;
4645
import javax.servlet.http.HttpServletResponse;
4746

@@ -62,7 +61,7 @@
6261
* @author Andre Azzolini (apazzolini)
6362
*/
6463
@Component("blCartStateFilter")
65-
public class CartStateFilter extends GenericFilterBean implements Ordered {
64+
public class CartStateFilter extends OncePerRequestFilter implements Ordered {
6665

6766
protected static final Log LOG = LogFactory.getLog(CartStateFilter.class);
6867

@@ -78,9 +77,9 @@ public class CartStateFilter extends GenericFilterBean implements Ordered {
7877
protected List<String> excludedOrderLockRequestPatterns;
7978

8079
@Override
81-
public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain)
80+
public void doFilterInternal(HttpServletRequest request, HttpServletResponse response, FilterChain chain)
8281
throws IOException, ServletException {
83-
cartStateProcessor.process(new ServletWebRequest((HttpServletRequest) request, (HttpServletResponse) response));
82+
cartStateProcessor.process(new ServletWebRequest(request, response));
8483

8584
if (!requestRequiresLock(request)) {
8685
chain.doFilter(request, response);

0 commit comments

Comments
 (0)