Made SuccessHandling aware of the loginUri (uri configurable) and will strip the loginUri to prevent a redirect back to the login page.

This fixes BroadleafCommerce#1271
This is related to BroadleafCommerce/QA#335

Author: Daniel Colgrove

admin/broadleaf-open-admin-platform/src/main/java/org/broadleafcommerce/openadmin/security/BroadleafAdminAuthenticationSuccessHandler.java

@@ -43,6 +43,8 @@ public class BroadleafAdminAuthenticationSuccessHandler extends SimpleUrlAuthent
 
     private RequestCache requestCache = new HttpSessionRequestCache();
 
+    private String loginUri = "/login"; //default login uri but can be overridden in admin security config
+    
     private static final String successUrlParameter = "successUrl=";
 
     @Resource(name = "blAdminSecurityRemoteService")
@@ -89,8 +91,39 @@ public void onAuthenticationSuccess(HttpServletRequest request, HttpServletRespo
                 targetUrl = targetUrl.substring(successUrlPosistion, nextParamPosistion);
             }
         }
-        
-        logger.debug("Redirecting to DefaultSavedRequest Url: " + targetUrl);
+
+        // Remove the login URI so we don't continuously redirect to the login page
+        targetUrl = removeLoginSegment(targetUrl);
+
+        if (logger.isDebugEnabled()) {
+            logger.debug("Redirecting to DefaultSavedRequest Url: " + targetUrl);
+        }
         getRedirectStrategy().sendRedirect(request, response, targetUrl);
     }
+    
+    /**
+     * Given the instance attribute loginUri, removes the loginUri from the passed url when present
+     * @param uri
+     * @return String
+     */
+    private String removeLoginSegment(String url) {
+      if ((url == null) || url.equals("")) {
+    	  return "/";
+      }
+      int lastSlashPos = url.lastIndexOf(loginUri);
+      if (lastSlashPos >= 0) {
+    	  return url.substring(0, lastSlashPos);
+      }
+      else {
+        return url;
+      }
+    } 
+
+	public String getLoginUri() {
+		return loginUri;
+	}
+
+	public void setLoginUri(String loginUri) {
+		this.loginUri = loginUri;
+	}
 }