chore(storage): delete unused samples

[alarconesparza]

Description

Fixes internal
b/347351975
b/347352330
b/347352075

Checklist

• I have followed Sample Format Guide
• pom.xml parent set to latest shared-configuration
• Appropriate changes to README are included in PR
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• Tests pass: mvn clean verify required
• Lint passes: mvn -P lint checkstyle:check required
• Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[gemini-code-assist]

Hello @alarconesparza, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request removes unused samples related to the XML API for Google Cloud Storage. Specifically, it deletes the storage/xml-api directory, which includes the cmdline-sample and serviceaccount-appengine-sample subdirectories. These samples appear to be outdated or no longer relevant, as indicated by the associated internal bug tickets.

Highlights

• Removal of XML API Samples: The entire storage/xml-api directory and its contents, including the command-line sample and the App Engine service account sample, have been removed.
• README Deletion: The README.md file in the storage/xml-api directory has been deleted, as it is no longer needed with the removal of the samples.
• Code Deletion: All source code, pom files, logging configurations, and web application configurations associated with the XML API samples have been removed.

Changelog

Click here to see the changelog

• storage/xml-api/README.md
  • Deleted the entire file.
• storage/xml-api/cmdline-sample/README.md
  • Deleted the entire file.
• storage/xml-api/cmdline-sample/logging.properties
  • Deleted the entire file.
• storage/xml-api/cmdline-sample/pom.xml
  • Deleted the entire file.
• storage/xml-api/cmdline-sample/src/main/java/StorageSample.java
  • Deleted the entire file.
• storage/xml-api/cmdline-sample/src/test/java/StorageSampleTest.java
  • Deleted the entire file.
• storage/xml-api/serviceaccount-appengine-sample/README.md
  • Deleted the entire file.
• storage/xml-api/serviceaccount-appengine-sample/pom.xml
  • Deleted the entire file.
• storage/xml-api/serviceaccount-appengine-sample/src/main/java/com/google/api/client/sample/storage/appengine/serviceaccount/StorageSample.java
  • Deleted the entire file.
• storage/xml-api/serviceaccount-appengine-sample/src/main/webapp/WEB-INF/appengine-web.xml
  • Deleted the entire file.
• storage/xml-api/serviceaccount-appengine-sample/src/main/webapp/WEB-INF/logging.properties
  • Deleted the entire file.
• storage/xml-api/serviceaccount-appengine-sample/src/main/webapp/WEB-INF/web.xml
  • Deleted the entire file.
• storage/xml-api/serviceaccount-appengine-sample/src/main/webapp/xsl/listing.xsl
  • Deleted the entire file.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Old samples fade away,
New code shines, a brighter day,
Obsolete no more,
Cleanliness ashore,
The codebase finds a better way.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request aims to delete unused samples from the storage XML API. The changes involve removing several files and directories related to the cmdline-sample and serviceaccount-appengine-sample. Overall, the changes seem straightforward, but it's crucial to ensure that these samples are indeed unused and that their removal doesn't negatively impact any existing documentation or functionality.

Summary of Findings

• Verification of Unused Samples: It's essential to verify that the samples being deleted are truly unused and that no other parts of the documentation or codebase depend on them. Confirming this is crucial to avoid unintended consequences.
• Impact on Documentation: Removing these samples might affect existing documentation that refers to them. Ensure that any references to these samples are updated or removed from the documentation to maintain accuracy.

Merge Readiness

The pull request appears to be a straightforward deletion of unused samples. However, before merging, it's crucial to verify that these samples are indeed unused and that their removal doesn't negatively impact any existing documentation or functionality. I am unable to approve this pull request, and recommend that others review and approve this code before merging.

[snippet-bot]

Here is the summary of changes.

You are about to delete 3 region tags.

• storage/xml-api/cmdline-sample/src/main/java/StorageSample.java:63, tag snippet
• storage/xml-api/cmdline-sample/src/test/java/StorageSampleTest.java:17, tag StorageSampleTest
• storage/xml-api/serviceaccount-appengine-sample/src/main/java/com/google/api/client/sample/storage/appengine/serviceaccount/StorageSample.java:75, tag snippet

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment