feat: migrate to 2.x samples and clear unused samples #10059
Conversation
product-auto-label
bot
added
the
samples
![gemini-code-assist[bot]](https://flashblogg.com:443/je/cache.php/https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @msampathkumar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request cleans up unused code samples in the vertexai/snippets/src/main/java/vertexai/gemini directory. It removes several Java files related to audio summarization, audio transcription, automatic function calling, chat discussions, complex function calling, controlled generation with MIME type and schema, Gemini translation, multimodal input, and safety settings. Additionally, it updates the SnippetsIT.java test file to remove tests associated with the deleted code samples.
Highlights
- Code Removal: Removes multiple unused Java code samples related to Gemini API functionalities.
- Test Cleanup: Updates the
SnippetsIT.javafile to remove corresponding tests for the deleted code samples. - Directory Cleanup: Cleans up the
vertexai/snippets/src/main/java/vertexai/geminidirectory by removing obsolete files.
Changelog
Click here to see the changelog
- vertexai/snippets/src/main/java/vertexai/gemini/AudioInputSummarization.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/AudioInputTranscription.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/AutomaticFunctionCalling.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/ChatDiscussion.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/ComplexFunctionCalling.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/ControlledGenerationMimeType.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/ControlledGenerationSchema.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/ControlledGenerationSchema2.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/ControlledGenerationSchema3.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/ControlledGenerationSchema4.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/GeminiTranslate.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/MultiTurnMultimodal.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/MultimodalAllInput.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/MultimodalVideoInput.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/PdfInput.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/SingleTurnMultimodal.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/WithSafetySettings.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/main/java/vertexai/gemini/WithSystemInstruction.java
- Removed the entire file as it contains an unused code sample.
- vertexai/snippets/src/test/java/vertexai/gemini/SnippetsIT.java
- Removed testChatSession() method.
- Removed testSafetySettings() method.
- Removed testComplexFunctionCalling() method.
- Removed testAutomaticFunctionCalling() method.
- Removed testAudioInputSummary() method.
- Removed testAudioInputTranscription() method.
- Removed testSystemInstruction() method.
- Removed testControlledGenerationWithMimeType() method.
- Removed testControlledGenerationWithJsonSchema() method.
- Removed testControlledGenerationWithJsonSchema2() method.
- Removed testControlledGenerationWithJsonSchema3() method.
- Removed testControlledGenerationWithJsonSchema4() method.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A code cleanup's gentle hand,
Removes what's no longer planned,
A leaner system,
Efficiency's prism,
Brings order back to the land.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes several unused code samples from the vertexai/snippets/src/main/java/vertexai/gemini directory. The removed files cover various functionalities, including audio summarization, audio transcription, automatic function calling, chat discussions, complex function calling, controlled generation with MIME types and schemas, Gemini translation, multi-turn multimodal interactions, multimodal input with video and images, PDF input, single-turn multimodal interactions, safety settings, and system instructions. The corresponding tests have also been removed. This cleanup helps to reduce the codebase size and improve maintainability.
Merge Readiness
The pull request removes unused code samples and associated tests, which should improve the overall quality and maintainability of the codebase. Since the changes primarily involve removing code, the risk of introducing new issues is low. I am unable to directly approve the pull request, and that users should have others review and approve this code before merging. Given the nature of the changes, the pull request appears ready for merging.
msampathkumar
changed the title
|
Started working on the bug fixes |
Description
bugs: b/407554370