Some updates...

Author: kevinmartintech

Development Application Settings/Red Gate/SQL Prompt/Snippets/cu-c9cc9091-91d1-4966-b4ba-655a34678f4a.json

@@ -0,0 +1,104 @@
+{
+  "metadata": {
+    "id": "b9530d2c-850d-46b0-b8b4-51a5899a376e",
+    "name": "Kevin Martin"
+  },
+  "whitespace": {
+    "wrapLinesLongerThan": 150
+  },
+  "lists": {
+    "placeFirstItemOnNewLine": "always",
+    "alignSubsequentItemsWithFirstItem": false,
+    "alignItemsAcrossClauses": false,
+    "alignAliases": true,
+    "alignComments": true,
+    "placeCommasBeforeItems": true,
+    "addSpaceAfterComma": false
+  },
+  "parentheses": {
+    "parenthesisStyle": "expandedSplit",
+    "indentParenthesesContents": true,
+    "collapseParenthesesShorterThan": 35
+  },
+  "casing": {
+    "reservedKeywords": "uppercase",
+    "builtInFunctions": "uppercase",
+    "builtInDataTypes": "lowercase",
+    "useObjectDefinitionCase": true
+  },
+  "dml": {
+    "addNewLineAfterDistinctAndTopClauses": true,
+    "collapseShortStatements": true,
+    "collapseStatementsShorterThan": 78,
+    "collapseShortSubqueries": true,
+    "collapseSubqueriesShorterThan": 78,
+    "listItems": {
+      "placeFromTableOnNewLine": "always",
+      "placeWhereConditionOnNewLine": "always",
+      "placeGroupByAndOrderByOnNewLine": "always"
+    }
+  },
+  "ddl": {
+    "parenthesisStyle": "expandedSplit",
+    "indentParenthesesContents": true,
+    "alignDataTypesAndConstraints": true,
+    "placeConstraintColumnsOnNewLines": "ifLongerOrMultipleColumns",
+    "indentClauses": true,
+    "placeFirstProcedureParameterOnNewLine": "always",
+    "collapseShortStatements": true,
+    "collapseStatementsShorterThan": 100
+  },
+  "controlFlow": {
+    "indentBeginAndEndKeywords": true,
+    "collapseStatementsShorterThan": 120
+  },
+  "cte": {
+    "parenthesisStyle": "expandedSplit",
+    "indentContents": true,
+    "placeColumnsOnNewLine": true,
+    "columnAlignment": "indented",
+    "asAlignment": "rightAligned"
+  },
+  "variables": {
+    "placeAssignedValueOnNewLineIfLongerThanMaxLineLength": false
+  },
+  "joinStatements": {
+    "join": {
+      "indentJoinTable": false
+    },
+    "on": {
+      "placeOnNewLine": false,
+      "keywordAlignment": "indented"
+    }
+  },
+  "insertStatements": {
+    "columns": {
+      "parenthesisStyle": "compactSimple",
+      "placeSubsequentColumnsOnNewLines": "ifLongerThanMaxLineLength"
+    },
+    "values": {
+      "parenthesisStyle": "compactSimple",
+      "indentContents": true,
+      "placeSubsequentValuesOnNewLines": "ifLongerThanMaxLineLength"
+    }
+  },
+  "caseExpressions": {
+    "placeExpressionOnNewLine": false,
+    "placeFirstWhenOnNewLine": "ifInputExpression",
+    "placeThenOnNewLine": true,
+    "collapseShortCaseExpressions": true,
+    "collapseCaseExpressionsShorterThan": 100
+  },
+  "operators": {
+    "comparison": {
+      "align": true
+    },
+    "andOr": {},
+    "between": {
+      "placeOnNewLine": false
+    },
+    "in": {
+      "placeFirstValueOnNewLine": "ifLongerThanMaxLineLength"
+    }
+  }
+}

Development Application Settings/Red Gate/SQL Prompt/Styles/Kevin Martin-b9530d2c-850d-46b0-b8b4-51a5899a376e.json

@@ -65,7 +65,6 @@
   },
   "joinStatements": {
     "join": {
-      "keywordAlignment": "toTable",
       "indentJoinTable": false
     },
     "on": {

Development Application Settings/Red Gate/SQL Prompt/Styles/Team Expanded-6d4cd025-b548-497f-bf21-3d5c64111b1f.json

@@ -1590,7 +1590,7 @@ This error catching and trowing methodology is the newest. [```THROW```](https:/
 ### Return Code Methodology (dbo.TestReturnCode)
 The return code methodology utilizes [```RETURN```](https://docs.microsoft.com/en-us/sql/t-sql/language-elements/return-transact-sql). ```RETURN```, exits unconditionally from a query or procedure. ```RETURN``` is immediate and complete and can be used at any point to exit from a procedure, batch, or statement block. Statements that follow RETURN are not executed.
 
-When ```THROW``` is utilized, a return code is not assigned. ```RETURN``` was commonly utilized with [```RAISERROR```](https://docs.microsoft.com/en-us/sql/t-sql/language-elements/raiserror-transact-sql) which never aborts execution, so ```RETURN``` could be used afterwards. (See [Using RAISERROR Instead of THROW](/SQL-Server-Development-Assessment/best-practices-and-potential-findings/sql-code-conventions#using-raiserror-instead-of-throw)). Utilizing ```RAISERROR``` with the return code would provide context to the error that occured to present to the user and log the error.
+When ```THROW``` is utilized, a return code is not assigned. ```RETURN``` was commonly utilized with [```RAISERROR```](https://docs.microsoft.com/en-us/sql/t-sql/language-elements/raiserror-transact-sql) which never aborts execution, so ```RETURN``` could be used afterwards. (See [Using RAISERROR Instead of THROW](/SQL-Server-Development-Assessment/best-practices-and-potential-findings/sql-code-conventions#using-raiserror-instead-of-throw)). Utilizing ```RAISERROR``` with the return code would provide context to the error that occurred to present to the user and log the error.
 
 ### Output Parameter Methodology (dbo.TestReturnCodeParameter)
 This methodology utilizes stored procedure ```OUTPUT``` parameters. Here you can set a return code and a return message that is passed back to the software code to present to the user and log the error

docs/findings/SQLCodeDevelopment.md

@@ -543,7 +543,9 @@ These are a 400 level tasks and please feel free to reach out to a DBA for assis
 ## Missing Index for Foreign Key
 **Check Id:** 21
 
-Each foreign key in your table should be included in an index. Start off with an index on just the foreign key column if you have no workload to tune a multi-column index. There is a real good chance the indexes will be used when queries join on the parent table.
+Each foreign key in your table should be included in an index in the primary key position. If you have a `UNIQUE NONCLUSTERED` index with multiple keys, ensure foreign key columns not in the primary key location also get their own `NONCLUSTERED` index in the primary key position.
+
+Start off with an index on just the foreign key column if you have no workload to tune a multi-column index. There is a real good chance the indexes will be used when queries join on the parent table.
 
 [Back to top](#top)