Skip to content

Commit 04f17de

Browse files
Merge pull request #395 from EmergentSoftware/dev
Removed flag.
2 parents 85b3b99 + 0f2c9c0 commit 04f17de

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

Development Application Settings/Red Gate/SQL Prompt/Styles/Team Collapsed-fcb648ec-57c1-48f9-a40f-d3e81de7b8de.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@
1616
"alignComments": true
1717
},
1818
"parentheses": {
19-
"parenthesisStyle": "expandedToStatement",
19+
"parenthesisStyle": "expandedSplit",
2020
"indentParenthesesContents": true,
21+
"collapseShortParenthesisContents": true,
2122
"collapseParenthesesShorterThan": 75
2223
},
2324
"casing": {

docs/findings/SQLCodeDevelopment.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -507,11 +507,11 @@ CREATE TABLE #Person (
507507
PersonId int NOT NULL IDENTITY(1, 1) PRIMARY KEY
508508
,FirstName nvarchar(100) NOT NULL
509509
,LastName nvarchar(128) NOT NULL
510-
,IsProcessedFlag bit NOT NULL DEFAULT (0)
510+
,IsProcessed bit NOT NULL DEFAULT (0)
511511
);
512512

513513
INSERT INTO
514-
#Person (FirstName, LastName, IsProcessedFlag)
514+
#Person (FirstName, LastName, IsProcessed)
515515
VALUES
516516
(N'Joel', N'Miller', 0);
517517

@@ -520,7 +520,7 @@ DECLARE
520520
,@FirstName nvarchar(100)
521521
,@LastName nvarchar(100);
522522

523-
WHILE EXISTS (SELECT * FROM #Person WHERE IsProcessedFlag = 0)
523+
WHILE EXISTS (SELECT * FROM #Person WHERE IsProcessed = 0)
524524
BEGIN
525525
SELECT TOP (1)
526526
@PersonId = P.PersonId
@@ -529,7 +529,7 @@ WHILE EXISTS (SELECT * FROM #Person WHERE IsProcessedFlag = 0)
529529
FROM
530530
#Person AS P
531531
WHERE
532-
P.IsProcessedFlag = 0
532+
P.IsProcessed = 0
533533
ORDER BY
534534
P.PersonId ASC;
535535

@@ -541,7 +541,7 @@ WHILE EXISTS (SELECT * FROM #Person WHERE IsProcessedFlag = 0)
541541
WHERE
542542
PersonId = @PersonId;
543543

544-
UPDATE #Person SET IsProcessedFlag = 1 WHERE PersonId = @PersonId;
544+
UPDATE #Person SET IsProcessed = 1 WHERE PersonId = @PersonId;
545545
END;
546546
```
547547

0 commit comments

Comments
 (0)