Skip to content

Commit 7525080

Browse files
hlovdalianfixes
authored andcommitted
Increment @failure_count if build_shared_library fails
1 parent 047ee72 commit 7525080

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
2525
- `arduino_ci.rb --help` no longer crashes
2626

2727
- Fix missing `LED_BUILTIN` definition for Arduino Due, Zero and Circuit Playground.
28+
- No longer ignore failures if the first step of compiling files for the
29+
unit test fails.
2830

2931
### Security
3032

exe/arduino_ci.rb

+3-1
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,9 @@ def perform_unit_tests(cpp_library, file_config)
442442
puts
443443
compilers.each do |gcc_binary|
444444
# before compiling the tests, build a shared library of everything except the test code
445-
next unless build_shared_library(gcc_binary, p, config, cpp_library)
445+
build_result = build_shared_library(gcc_binary, p, config, cpp_library)
446+
@failure_count += 1 unless build_result
447+
next unless build_result
446448

447449
# now build and run each test using the shared library build above
448450
config.allowable_unittest_files(cpp_library.test_files).each do |unittest_path|

0 commit comments

Comments
 (0)