Use arduino_ci GitHub Action; fix destructor (#8)

* Update to use new `arduino_ci` GitHub Action
* Move destructor out of header; remove extra delete.

Author: James Foster

.github/workflows/arduino_ci.yml

@@ -0,0 +1,12 @@
+---
+name: Arduino CI
+
+on: [push, pull_request]
+
+jobs:
+  arduino_ci:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: Arduino-CI/action@v0.1.0

scripts/testAndBuild.sh

@@ -1,4 +1,4 @@
 #! /bin/sh
 bundle config --local path vendor/bundle
 bundle install
-bundle exec arduino_ci.rb --skip-examples-compilation
+bundle exec arduino_ci.rb

src/Adafruit_SPIDevice.cpp

@@ -75,6 +75,14 @@ Adafruit_SPIDevice::Adafruit_SPIDevice(int8_t cspin, int8_t sckpin,
   _spi = NULL;
 }
 
+// Release memory allocated in constructors
+Adafruit_SPIDevice::~Adafruit_SPIDevice() {
+  if (_spiSetting) {
+    delete _spiSetting;
+    _spiSetting = nullptr;
+  }
+}
+
 /*!
  *    @brief  Initializes SPI bus and sets CS pin high
  *    @return Always returns true because there's no way to test success of SPI

src/Adafruit_SPIDevice.h

@@ -64,17 +64,7 @@ class Adafruit_SPIDevice {
                      uint32_t freq = 1000000,
                      BitOrder dataOrder = SPI_BITORDER_MSBFIRST,
                      uint8_t dataMode = SPI_MODE0);
-
-  ~Adafruit_SPIDevice() {
-    if (_spi) {
-      delete _spi;
-      _spi = nullptr;
-    }
-    if (_spiSetting) {
-      delete _spiSetting;
-      _spiSetting = nullptr;
-    }
-  }
+  ~Adafruit_SPIDevice();
 
   bool begin(void);
   bool read(uint8_t *buffer, size_t len, uint8_t sendvalue = 0xFF);