Update to latest from Adafruit; Update to Arduino-CI/action@stable-1.x (#9)

* Make compatible with Heltec's CubeCell Arduino-core

The functions fast pin-I/O uses are currently missing, so don't define BUSIO_USE_FAST_PINIO. Also, we need typedef for BitOrder, but it refuses to compile without also including Arduino.h, at least under PlatformIO.

* Update Adafruit_SPIDevice.h

* Buffer arguments of write functions are changed to const so that the functions cannot change the content of the buffer. Also, if the I2C device's register address are define using const rather than #define, the functions can accept those too.

* Applied clang formatting.

* Added function description.

* Update Adafruit_SPIDevice.cpp

The SPI.cpp that the STM32 project uses does not have a transfer method with both a buffer and a length.  Changes to this file uses a transfer method that just needs a single 8 bit character.

* Update Adafruit_SPIDevice.cpp

Added code to define 'i'.

* Update Adafruit_SPIDevice.cpp

Adjusted syntax of added 'for' statement

* Update Adafruit_SPIDevice.cpp

* Update Adafruit_SPIDevice.cpp

Changing #ifdef construct to make STM32 a special case.

* Updated #if #elif structure.

Update #if #elif structure to avoid nested #ifdef's

* Removed extra blank line

* Update Adafruit_SPIDevice.cpp

* Revert "Added function description."

This reverts commit 0475316.

* Write functions' description updated that explains why the buffer arguments are const.

* Bump to 1.7.0

* Release memory allocated in constructors

* Edit comment to match other functions.

* Bump to 1.7.1

* Define the meaning of 'type' for BusIO Registers

Addressed issue adafruit#19 by updating register consts with suggested descriptions.

Co-Authored-By: jayjlawrence <1862335+jayjlawrence@users.noreply.github.com>

* Bump to 1.7.2

* Remove duplicate definition of destructor.

Co-authored-by: WereCatf <werecatf@gmail.com>
Co-authored-by: Limor "Ladyada" Fried <limor@ladyada.net>
Co-authored-by: DESKTOP\fahadmirza <fahadmirza8@gmail.com>
Co-authored-by: howard-wa9axq <75182246+howard-wa9axq@users.noreply.github.com>
Co-authored-by: Dylan Herrada <33632497+dherrada@users.noreply.github.com>
Co-authored-by: Stuart Feichtinger <stuart.feichtinger@gmail.com>
Co-authored-by: jayjlawrence <1862335+jayjlawrence@users.noreply.github.com>
Co-authored-by: James Foster <git@jgfoster.net>

Author: 9 people

.github/workflows/arduino_ci.yml

@@ -9,4 +9,4 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-      - uses: Arduino-CI/action@v0.1.0
+      - uses: Arduino-CI/action@stable-1.x

library.properties

@@ -1,5 +1,5 @@
 name=Adafruit BusIO
-version=1.6.0
+version=1.7.2
 author=Adafruit
 maintainer=Adafruit <info@adafruit.com>
 sentence=This is a library for abstracting away UART, I2C and SPI interfacing

src/Adafruit_BusIO_Register.h

@@ -7,8 +7,21 @@
 
 typedef enum _Adafruit_BusIO_SPIRegType {
   ADDRBIT8_HIGH_TOREAD = 0,
+  /*!<
+   * ADDRBIT8_HIGH_TOREAD
+   * When reading a register you must actually send the value 0x80 + register
+   * address to the device. e.g. To read the register 0x0B the register value
+   * 0x8B is sent and to write 0x0B is sent.
+   */
   AD8_HIGH_TOREAD_AD7_HIGH_TOINC = 1,
+
   ADDRBIT8_HIGH_TOWRITE = 2,
+  /*!<
+   * ADDRBIT8_HIGH_TOWRITE
+   * When writing to a register you must actually send the value 0x80 +
+   * the register address to the device. e.g. To write to the register 0x19 the
+   * register value 0x99 is sent and to read 0x19 is sent.
+   */
 } Adafruit_BusIO_SPIRegType;
 
 /*!

src/Adafruit_I2CDevice.cpp

@@ -58,16 +58,19 @@ bool Adafruit_I2CDevice::detected(void) {
 /*!
  *    @brief  Write a buffer or two to the I2C device. Cannot be more than
  * maxBufferSize() bytes.
- *    @param  buffer Pointer to buffer of data to write
+ *    @param  buffer Pointer to buffer of data to write. This is const to
+ *            ensure the content of this buffer doesn't change.
  *    @param  len Number of bytes from buffer to write
  *    @param  prefix_buffer Pointer to optional array of data to write before
- * buffer. Cannot be more than maxBufferSize() bytes.
+ * buffer. Cannot be more than maxBufferSize() bytes. This is const to
+ *            ensure the content of this buffer doesn't change.
  *    @param  prefix_len Number of bytes from prefix buffer to write
  *    @param  stop Whether to send an I2C STOP signal on write
  *    @return True if write was successful, otherwise false.
  */
-bool Adafruit_I2CDevice::write(uint8_t *buffer, size_t len, bool stop,
-                               uint8_t *prefix_buffer, size_t prefix_len) {
+bool Adafruit_I2CDevice::write(const uint8_t *buffer, size_t len, bool stop,
+                               const uint8_t *prefix_buffer,
+                               size_t prefix_len) {
   if ((len + prefix_len) > maxBufferSize()) {
     // currently not guaranteed to work if more than 32 bytes!
     // we will need to find out if some platforms have larger
@@ -200,7 +203,7 @@ bool Adafruit_I2CDevice::read(uint8_t *buffer, size_t len, bool stop) {
  *    @param  stop Whether to send an I2C STOP signal between the write and read
  *    @return True if write & read was successful, otherwise false.
  */
-bool Adafruit_I2CDevice::write_then_read(uint8_t *write_buffer,
+bool Adafruit_I2CDevice::write_then_read(const uint8_t *write_buffer,
                                          size_t write_len, uint8_t *read_buffer,
                                          size_t read_len, bool stop) {
   if (!write(write_buffer, write_len, stop)) {

src/Adafruit_I2CDevice.h

@@ -12,9 +12,9 @@ class Adafruit_I2CDevice {
   bool detected(void);
 
   bool read(uint8_t *buffer, size_t len, bool stop = true);
-  bool write(uint8_t *buffer, size_t len, bool stop = true,
-             uint8_t *prefix_buffer = NULL, size_t prefix_len = 0);
-  bool write_then_read(uint8_t *write_buffer, size_t write_len,
+  bool write(const uint8_t *buffer, size_t len, bool stop = true,
+             const uint8_t *prefix_buffer = NULL, size_t prefix_len = 0);
+  bool write_then_read(const uint8_t *write_buffer, size_t write_len,
                        uint8_t *read_buffer, size_t read_len,
                        bool stop = false);
   bool setSpeed(uint32_t desiredclk);

src/Adafruit_SPIDevice.cpp

@@ -75,7 +75,9 @@ Adafruit_SPIDevice::Adafruit_SPIDevice(int8_t cspin, int8_t sckpin,
   _spi = NULL;
 }
 
-// Release memory allocated in constructors
+/*!
+ *    @brief  Release memory allocated in constructors
+ */
 Adafruit_SPIDevice::~Adafruit_SPIDevice() {
   if (_spiSetting) {
     delete _spiSetting;
@@ -126,12 +128,15 @@ void Adafruit_SPIDevice::transfer(uint8_t *buffer, size_t len) {
   if (_spi) {
     // hardware SPI is easy
 
-#ifdef SPARK
+#if defined(SPARK)
     _spi->transfer(buffer, buffer, len, NULL);
+#elif defined(STM32)
+    for (size_t i = 0; i < len; i++) {
+      _spi->transfer(buffer[i]);
+    }
 #else
     _spi->transfer(buffer, len);
 #endif
-
     return;
   }
 

src/Adafruit_SPIDevice.h

@@ -17,7 +17,7 @@ typedef enum _BitOrder {
   SPI_BITORDER_LSBFIRST = LSBFIRST,
 } BitOrder;
 
-#elif defined(ESP32)
+#elif defined(ESP32) || defined(__ASR6501__)
 
 // some modern SPI definitions don't have BitOrder enum and have different SPI
 // mode defines
@@ -47,7 +47,9 @@ typedef uint32_t BusIO_PortMask;
     !defined(ARDUINO_ARCH_MBED)
 typedef volatile uint32_t BusIO_PortReg;
 typedef uint32_t BusIO_PortMask;
+#if not defined(__ASR6501__)
 #define BUSIO_USE_FAST_PINIO
+#endif
 
 #else
 #undef BUSIO_USE_FAST_PINIO