Skip to content

Commit b1b3286

Browse files
refactor: user search-bar replaces ion-input
1 parent 0ac67e4 commit b1b3286

File tree

3 files changed

+14
-34
lines changed

3 files changed

+14
-34
lines changed

src/app/pages/user-search/user-search.page.html

+8-15
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,14 @@
77
</ion-toolbar>
88
</ion-header>
99
<ion-content padding>
10-
<ion-list>
11-
<ion-item>
12-
<ion-input
13-
[(ngModel)]="username"
14-
type="text"
15-
placeholder="github username"
16-
>
17-
</ion-input>
18-
<ion-buttons>
19-
<ion-button (click)="getRepos()" color="primary" icon-end>
20-
<ion-icon name="search"></ion-icon>
21-
</ion-button>
22-
</ion-buttons>
23-
</ion-item>
24-
</ion-list>
10+
<ion-searchbar
11+
color="primary"
12+
type="search"
13+
placeholder="search name"
14+
[debounce]="1000"
15+
(ionInput)="handleInput($event)"
16+
>
17+
</ion-searchbar>
2518
<ion-card *ngFor="let repo of repos$ | async; let index = index;">
2619
<ion-card-header> {{ repo.name }} </ion-card-header>
2720
<ion-card-content> {{ repo.description }} </ion-card-content>
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { GithubService } from "./../../services/github.service";
2-
import { Component, OnInit } from "@angular/core";
2+
import { Component } from "@angular/core";
33
import { Observable } from "rxjs";
44
import { Repo } from "./models/repo";
55

@@ -9,17 +9,16 @@ import { Repo } from "./models/repo";
99
styleUrls: ["./user-search.page.scss"],
1010
providers: [GithubService],
1111
})
12-
export class UserSearchPage implements OnInit {
12+
export class UserSearchPage {
1313
results: Observable<any>;
1414
public repos$: Observable<Repo[]>;
1515
public username: string;
1616

1717
constructor(private githubService: GithubService) {}
1818

19-
ngOnInit() {}
20-
21-
getRepos(): void {
19+
// Input username to search for Github repos
20+
handleInput(event: CustomEvent): void {
21+
this.username = event.detail.value.toLowerCase();
2222
this.repos$ = this.githubService.getRepos(this.username);
23-
console.log(this.repos$.subscribe((x) => console.log(x)));
2423
}
2524
}

src/app/services/github.service.ts

+1-13
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,7 @@ import { Repo } from "../pages/user-search/models/repo";
1010
export class GithubService {
1111
constructor(private http: HttpClient) {}
1212

13-
/* searchData(username: string): Observable<any> {
14-
return this.http.get(`https://api.github.com/users/${username}/repos`)
15-
.pipe(
16-
map(results => {
17-
console.log('RAW: ', results);
18-
return results['Search'];
19-
})
20-
);
21-
} */
2213
getRepos(username: string): Observable<any> {
23-
const returns = this.http.get(`https://api.github.com/users/${username}/repos`);
24-
console.log(returns.subscribe((x) => console.log(x)));
25-
console.log('returns type', typeof(returns));
26-
return returns;
14+
return this.http.get(`https://api.github.com/users/${username}/repos`);
2715
}
2816
}

0 commit comments

Comments
 (0)