add tests for config

Author: davidhyman

src/snippet/cli.py

@@ -5,7 +5,7 @@
 
 def get_cli_opts():
     parser = argparse.ArgumentParser()
-    parser.add_argument('config', help='path to config file')
+    parser.add_argument('--config', type=str, help='path to config file')
     return parser
 
 

src/snippet/config.py

@@ -34,9 +34,11 @@ def get_config(config_path=None, **options):
     new_options = {}
     if config_path or os.environ.get('SNIPPET_CONFIG_PATH'):
         with open(config_path) as f:
-            new_options.update(toml.load(f))
+            config_file_contents = toml.load(f)
+            snippet_config = config_file_contents['snippet']
+            new_options.update(snippet_config)
     new_options.update(options)
     config = Config()
-    for k, v in new_options:
+    for k, v in new_options.items():
         setattr(config, k, v)
     return config

tests/test_config.py

@@ -0,0 +1,44 @@
+import os
+import shutil
+import subprocess
+import sys
+import textwrap
+import unittest
+
+import snippet
+
+
+class Test(unittest.TestCase):
+    tmpdir = os.path.join(os.path.dirname(os.path.dirname(__file__)), 'tmp_test_dir')
+
+    @classmethod
+    def setUpClass(cls):
+        # use a plain directory not-really-in-tmp to avoid cross-process perms issues in windows
+        os.makedirs(cls.tmpdir)
+        cls.tmp_fp = os.path.join(cls.tmpdir, 'config.toml')
+        with open(cls.tmp_fp, 'w') as fh:
+            fh.write(textwrap.dedent("""
+            [snippet]
+            input_glob = '*'
+            end_flag = 'custom value'
+            stop_on_first_failure = true
+            foo = 'bar'            
+            """).lstrip())
+
+    @classmethod
+    def tearDownClass(cls):
+        shutil.rmtree(cls.tmpdir)
+
+    def test_config_from_file(self):
+        config = snippet.config.get_config(config_path=self.tmp_fp)
+        self.assertEqual(config.end_flag, 'custom value')
+        self.assertEqual(config.foo, 'bar')
+
+    def test_config_from_cli(self):
+        with self.assertRaises(subprocess.CalledProcessError) as ctx:
+            subprocess.check_output(
+                [sys.executable, '-m', 'snippet', '--config', self.tmp_fp],
+                cwd=self.tmpdir,
+                stderr=subprocess.STDOUT
+            )
+        self.assertIn('snippet.exceptions', str(ctx.exception.output))

tmp_test_dirs/config.toml

@@ -0,0 +1,5 @@
+[snippet]
+input_glob = '*.py'
+end_flag = 'custom value'
+stop_on_first_failure = true
+foo = 'bar'