Skip to content

Commit fb257ee

Browse files
authored
Upgrade master to Ubuntu 24.04 (phpGH-16704)
1 parent 40997c2 commit fb257ee

File tree

11 files changed

+36
-15
lines changed

11 files changed

+36
-15
lines changed

.github/actions/apt-x32/action.yml

-2
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,11 @@ runs:
3333
libsodium-dev:i386 \
3434
libsqlite3-dev:i386 \
3535
libssl-dev:i386 \
36-
libtidy-dev:i386 \
3736
libwebp-dev:i386 \
3837
libxml2-dev:i386 \
3938
libxml2-dev:i386 \
4039
libxpm-dev:i386 \
4140
libxslt1-dev:i386 \
42-
libzip-dev:i386 \
4341
locales \
4442
make \
4543
pkg-config:i386 \

.github/actions/configure-x32/action.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ runs:
1010
run: |
1111
set -x
1212
13+
export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:/usr/lib/i386-linux-gnu/pkgconfig"
1314
./buildconf --force
1415
export CFLAGS="-m32 -msse2"
1516
export CXXFLAGS="-m32 -msse2"
@@ -33,12 +34,10 @@ runs:
3334
--with-freetype \
3435
--with-xpm \
3536
--enable-exif \
36-
--with-zip \
3737
--with-zlib \
3838
--enable-soap \
3939
--enable-xmlreader \
4040
--with-xsl \
41-
--with-tidy \
4241
--enable-sysvsem \
4342
--enable-sysvshm \
4443
--enable-shmop \

.github/workflows/push.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ jobs:
7878
zts: true
7979
asan: true
8080
name: "LINUX_X64_${{ matrix.debug && 'DEBUG' || 'RELEASE' }}_${{ matrix.zts && 'ZTS' || 'NTS' }}${{ matrix.asan && '_ASAN' || '' }}"
81-
runs-on: ubuntu-${{ !matrix.asan && '22' || '24' }}.04
81+
runs-on: ubuntu-24.04
8282
timeout-minutes: 50
8383
steps:
8484
- name: git checkout
@@ -142,7 +142,7 @@ jobs:
142142
runs-on: ubuntu-latest
143143
timeout-minutes: 50
144144
container:
145-
image: ubuntu:20.04
145+
image: ubuntu:24.04
146146
env:
147147
MYSQL_TEST_HOST: mysql
148148
PDO_MYSQL_TEST_DSN: mysql:host=mysql;dbname=test
@@ -255,7 +255,7 @@ jobs:
255255
BENCHMARKING:
256256
name: BENCHMARKING
257257
if: github.repository == 'php/php-src' || github.event_name == 'pull_request'
258-
runs-on: ubuntu-22.04
258+
runs-on: ubuntu-24.04
259259
timeout-minutes: 50
260260
steps:
261261
- name: git checkout

.github/workflows/root.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ jobs:
5252
libmysqlclient_with_mysqli: ${{ (matrix.branch.version[0] == 8 && matrix.branch.version[1] == 1) }}
5353
run_alpine: ${{ (matrix.branch.version[0] == 8 && matrix.branch.version[1] >= 4) || matrix.branch.version[0] >= 9 }}
5454
run_macos_arm64: ${{ (matrix.branch.version[0] == 8 && matrix.branch.version[1] >= 4) || matrix.branch.version[0] >= 9 }}
55-
ubuntu_version: ${{ ((matrix.branch.version[0] == 8 && matrix.branch.version[1] >= 3) || matrix.branch.version[0] >= 9) && '22.04' || '20.04' }}
55+
ubuntu_version: ${{
56+
(((matrix.branch.version[0] == 8 && matrix.branch.version[1] >= 4) || matrix.branch.version[0] >= 9) && '24.04')
57+
|| ((matrix.branch.version[0] == 8 && matrix.branch.version[1] >= 3) && '22.04')
58+
|| '20.04' }}
5659
windows_version: ${{ ((matrix.branch.version[0] == 8 && matrix.branch.version[1] >= 4) || matrix.branch.version[0] >= 9) && '2022' || '2019' }}
5760
secrets: inherit

Zend/zend_portability.h

+7
Original file line numberDiff line numberDiff line change
@@ -515,6 +515,13 @@ extern "C++" {
515515
# undef HAVE_FUNC_ATTRIBUTE_IFUNC
516516
#endif
517517

518+
#if __has_feature(memory_sanitizer)
519+
# include <sanitizer/msan_interface.h>
520+
# define MSAN_UNPOISON(value) __msan_unpoison(&(value), sizeof(value))
521+
#else
522+
# define MSAN_UNPOISON(value)
523+
#endif
524+
518525
/* Only use ifunc resolvers if we have __builtin_cpu_supports() and __builtin_cpu_init(),
519526
* otherwise the use of zend_cpu_supports() may not be safe inside ifunc resolvers. */
520527
#if defined(HAVE_FUNC_ATTRIBUTE_IFUNC) && defined(HAVE_FUNC_ATTRIBUTE_TARGET) && \

ext/curl/tests/bug77535.phpt

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
Bug #77535 (Invalid callback, h2 server push)
33
--EXTENSIONS--
44
curl
5-
--XLEAK--
5+
--XFAIL--
66
--SKIPIF--
77
<?php
88
include 'skipif-nocaddy.inc';

ext/curl/tests/curl_pushfunction_trampoline.phpt

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
Test trampoline for curl option CURLMOPT_PUSHFUNCTION
33
--EXTENSIONS--
44
curl
5-
--XLEAK--
5+
--XFAIL--
66
--SKIPIF--
77
<?php
88
include 'skipif-nocaddy.inc';

ext/pcntl/tests/pcntl_setns_basic.phpt

+8
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,14 @@ posix
77
<?php
88
if (!function_exists("pcntl_setns")) die("skip pcntl_setns is not available");
99
if (getenv('SKIP_ASAN')) die('skip Timeouts under ASAN');
10+
11+
$pid = pcntl_fork();
12+
if ($pid == -1) die("skip pcntl_fork failed");
13+
if ($pid != 0) {
14+
if (@pcntl_setns($pid, CLONE_NEWPID) === false && pcntl_get_last_error() == PCNTL_EPERM) {
15+
die("skip Insufficient privileges to use pcntl_setns()");
16+
}
17+
}
1018
?>
1119
--FILE--
1220
<?php

ext/pcntl/tests/pcntl_setns_newpid.phpt

+8-1
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,15 @@ posix
66
--SKIPIF--
77
<?php
88
if (!function_exists("pcntl_setns")) die("skip pcntl_setns is not available");
9-
if (posix_getuid() !== 0) die('skip Test needs root user');
109
if (getenv('SKIP_ASAN')) die('skip Timeouts under ASAN');
10+
11+
$pid = pcntl_fork();
12+
if ($pid == -1) die("skip pcntl_fork failed");
13+
if ($pid != 0) {
14+
if (@pcntl_setns($pid, CLONE_NEWPID) === false && pcntl_get_last_error() == PCNTL_EPERM) {
15+
die("skip Insufficient privileges to use pcntl_setns()");
16+
}
17+
}
1118
?>
1219
--FILE--
1320
<?php

ext/pdo_odbc/tests/long_columns.phpt

+2-4
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,8 @@ PDO ODBC "long" columns
44
pdo_odbc
55
--SKIPIF--
66
<?php
7-
// make sure there is an ODBC driver and a DSN, or the test will fail
8-
include 'ext/pdo/tests/pdo_test.inc';
9-
$config = PDOTest::get_config('ext/pdo_odbc/tests/common.phpt');
10-
if (!isset($config['ENV']['PDOTEST_DSN']) || $config['ENV']['PDOTEST_DSN']===false) print 'skip';
7+
require 'ext/pdo/tests/pdo_test.inc';
8+
PDOTest::skip();
119
?>
1210
--FILE--
1311
<?php

ext/standard/basic_functions.c

+1
Original file line numberDiff line numberDiff line change
@@ -1182,6 +1182,7 @@ PHP_FUNCTION(time_nanosleep)
11821182
RETURN_TRUE;
11831183
} else if (errno == EINTR) {
11841184
array_init(return_value);
1185+
MSAN_UNPOISON(php_rem);
11851186
add_assoc_long_ex(return_value, "seconds", sizeof("seconds")-1, php_rem.tv_sec);
11861187
add_assoc_long_ex(return_value, "nanoseconds", sizeof("nanoseconds")-1, php_rem.tv_nsec);
11871188
return;

0 commit comments

Comments
 (0)