Revert "Fix #81424: PCRE2 10.35 JIT performance regression"

cmb69 · cmb69 · commit a19f655b845e · 2021-10-05T11:49:04.000+02:00
This reverts commit a247138. Fixing the performance regression, apparently fixes a functional regression[1], so we revert for now. [1] <PCRE2Project/pcre2#21> Closes phpGH-7556.
diff --git a/NEWS b/NEWS
@@ -17,9 +17,6 @@ PHP                                                                        NEWS
   . Fixed bug #61700 (FILTER_FLAG_IPV6/FILTER_FLAG_NO_PRIV|RES_RANGE failing).
     (cmb, Nikita)
 
-- PCRE:
-  . Fixed bug #81424 (PCRE2 10.35 JIT performance regression). (cmb)
-
 - SPL:
   . Fixed bug #80663 (Recursive SplFixedArray::setSize() may cause double-free).
     (cmb, Nikita, Tyson Andre)
diff --git a/ext/pcre/pcre2lib/pcre2_jit_compile.c b/ext/pcre/pcre2lib/pcre2_jit_compile.c
@@ -11152,7 +11152,7 @@ early_fail_type = (early_fail_ptr & 0x7);
 early_fail_ptr >>= 3;
 
 /* During recursion, these optimizations are disabled. */
-if (common->early_fail_start_ptr == 0 && common->fast_forward_bc_ptr == NULL)
+if (common->early_fail_start_ptr == 0)
   {
   early_fail_ptr = 0;
   early_fail_type = type_skip;

Original file line number	Diff line number	Diff line change
`@@ -11152,7 +11152,7 @@ early_fail_type = (early_fail_ptr & 0x7);`
`11152`	`11152`	`early_fail_ptr >>= 3;`
`11153`	`11153`
`11154`	`11154`	`/* During recursion, these optimizations are disabled. */`
`11155`		`-if (common->early_fail_start_ptr == 0 && common->fast_forward_bc_ptr == NULL)`
	`11155`	`+if (common->early_fail_start_ptr == 0)`
`11156`	`11156`	`{`
`11157`	`11157`	`early_fail_ptr = 0;`
`11158`	`11158`	`early_fail_type = type_skip;`