* abort install when an extension fails to build (patch by ja at

stigsb · stigsb · commit 9e21b2eee469 · 2003-03-21T07:57:27.000Z
morrdusk dot net)
diff --git a/pear/PEAR/Builder.php b/pear/PEAR/Builder.php
@@ -252,10 +252,14 @@ function build($descfile, $callback = null)
         }
         foreach ($to_run as $cmd) {
             $err = $this->_runCommand($cmd, $callback);
-            if (PEAR::isError($err) && !$err) {
+            if (PEAR::isError($err)) {
                 chdir($old_cwd);
                 return $err;
             }
+            if (!$err) {
+                chdir($old_cwd);
+                return $this->raiseError("`$cmd' failed");
+            }
         }
         if (!($dp = opendir("modules"))) {
             chdir($old_cwd);

Original file line number	Diff line number	Diff line change
`@@ -252,10 +252,14 @@ function build($descfile, $callback = null)`
`252`	`252`	`}`
`253`	`253`	`foreach ($to_run as $cmd) {`
`254`	`254`	`$err = $this->_runCommand($cmd, $callback);`
`255`		`- if (PEAR::isError($err) && !$err) {`
	`255`	`+ if (PEAR::isError($err)) {`
`256`	`256`	`chdir($old_cwd);`
`257`	`257`	`return $err;`
`258`	`258`	`}`
	`259`	`+ if (!$err) {`
	`260`	`+ chdir($old_cwd);`
	`261`	+ return $this->raiseError("`$cmd' failed");
	`262`	`+ }`
`259`	`263`	`}`
`260`	`264`	`if (!($dp = opendir("modules"))) {`
`261`	`265`	`chdir($old_cwd);`