Skip to content

Commit 9467ffb

Browse files
authored
Autotools: Remove obsolete config.status invocations (php#15185)
This was once added to fix the bug https://bugs.php.net/13561 because the phpize and php-config scripts were located in the pear subdirectory and were installed only when --with-pear option was used. Then in the 20c4328 scripts were moved to scripts subdirectory with this mechanism used in the generated Makefile when running 'make install' command. Before the AC_CONFIG_FILES was introduced to Autoconf AC_OUTPUT once accepted arguments. This signature is obsolete in current Autoconf versions. The old obsolete config.status invocation: CONFIG_FILES=... ./config.status And the new invocation is (if used with AC_CONFIG_FILES in the code): ./config.status --file=... Instead, this simply removes the redundant phpize and php-config generation with the old obsolete config.status invocations as these files are always generated in the php-src build context.
1 parent 0339d8c commit 9467ffb

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

scripts/Makefile.frag

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ install-build:
3333
$(INSTALL) $(BUILD_FILES_EXEC) $(INSTALL_ROOT)$(phpbuilddir) && \
3434
$(INSTALL_DATA) $(BUILD_FILES) $(INSTALL_ROOT)$(phpbuilddir))
3535

36-
install-programs: $(builddir)/phpize $(builddir)/php-config
36+
install-programs:
3737
@echo "Installing helper programs: $(INSTALL_ROOT)$(bindir)/"
3838
@$(mkinstalldirs) $(INSTALL_ROOT)$(bindir)
3939
@for prog in $(bin_SCRIPTS); do \
@@ -46,9 +46,3 @@ install-programs: $(builddir)/phpize $(builddir)/php-config
4646
echo " page: $(program_prefix)$${page}$(program_suffix).1"; \
4747
$(INSTALL_DATA) $(builddir)/man1/$${page}.1 $(INSTALL_ROOT)$(mandir)/man1/$(program_prefix)$${page}$(program_suffix).1; \
4848
done
49-
50-
$(builddir)/phpize: $(srcdir)/phpize.in $(top_builddir)/config.status
51-
(CONFIG_FILES=$@ CONFIG_HEADERS= $(top_builddir)/config.status)
52-
53-
$(builddir)/php-config: $(srcdir)/php-config.in $(top_builddir)/config.status
54-
(CONFIG_FILES=$@ CONFIG_HEADERS= $(top_builddir)/config.status)

0 commit comments

Comments
 (0)