Skip to content

Commit 652baa7

Browse files
committed
- Add note how php_error() messages SHOULD (rfc2119) look like.
1 parent 0e50ac4 commit 652baa7

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

CODING_STANDARDS

+7
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,13 @@ Exceptions:
5656
to parse URL", "Unable to connect to URL server" and "Unable
5757
to fetch URL text", respectively.
5858

59+
It has been silently agreed to prefix every php_error() message with the
60+
name of the current function if applicable:
61+
62+
php_error(E_WHATEVER, "%s(): Desc.", get_active_function_name(TSRMLS_C));
63+
64+
Fixing ("unifying") existing php_error() message is a good thing [tm].
65+
5966
[6] NEVER USE strncat(). If you're absolutely sure you know what you're doing,
6067
check its man page again, and only then, consider using it, and even then,
6168
try avoiding it.

0 commit comments

Comments
 (0)