Skip to content

Commit 248b5f5

Browse files
authored
Remove useless NULL-check in phpdbg_print (php#13853)
&method->op_array cannot possibly be NULL because it takes a pointer to a field of method.
1 parent 18496cc commit 248b5f5

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

sapi/phpdbg/phpdbg_print.c

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -55,15 +55,13 @@ static inline void phpdbg_print_function_helper(zend_function *method) /* {{{ */
5555
case ZEND_USER_FUNCTION: {
5656
zend_op_array* op_array = &(method->op_array);
5757

58-
if (op_array) {
59-
zend_dump_op_array(op_array, ZEND_DUMP_LINE_NUMBERS, NULL, NULL);
60-
61-
for (uint32_t i = 0; i < op_array->num_dynamic_func_defs; i++) {
62-
zend_op_array *def = op_array->dynamic_func_defs[i];
63-
phpdbg_out("\ndynamic def: %i, function name: %.*s\n",
64-
i, (int) ZSTR_LEN(def->function_name), ZSTR_VAL(def->function_name));
65-
zend_dump_op_array(def, ZEND_DUMP_LINE_NUMBERS, NULL, NULL);
66-
}
58+
zend_dump_op_array(op_array, ZEND_DUMP_LINE_NUMBERS, NULL, NULL);
59+
60+
for (uint32_t i = 0; i < op_array->num_dynamic_func_defs; i++) {
61+
zend_op_array *def = op_array->dynamic_func_defs[i];
62+
phpdbg_out("\ndynamic def: %i, function name: %.*s\n",
63+
i, (int) ZSTR_LEN(def->function_name), ZSTR_VAL(def->function_name));
64+
zend_dump_op_array(def, ZEND_DUMP_LINE_NUMBERS, NULL, NULL);
6765
}
6866
} break;
6967

0 commit comments

Comments
 (0)