ext/standard/dir.c: Directory class should behave like other resource objects

Author: Girgias

ext/standard/dir.c

@@ -48,10 +48,17 @@ php_dir_globals dir_globals;
 #endif
 
 static zend_class_entry *dir_class_entry_ptr;
+static zend_object_handlers dir_class_object_handlers;
 
 #define Z_DIRECTORY_PATH_P(zv) OBJ_PROP_NUM(Z_OBJ_P(zv), 0)
 #define Z_DIRECTORY_HANDLE_P(zv) OBJ_PROP_NUM(Z_OBJ_P(zv), 1)
 
+static zend_function *dir_class_get_constructor(zend_object *object)
+{
+	zend_throw_error(NULL, "Cannot directly construct Directory, use dir() instead");
+	return NULL;
+}
+
 #define FETCH_DIRP() \
 	myself = getThis(); \
 	if (!myself) { \
@@ -115,6 +122,12 @@ PHP_MINIT_FUNCTION(dir)
 	register_dir_symbols(module_number);
 
 	dir_class_entry_ptr = register_class_Directory();
+	dir_class_entry_ptr->default_object_handlers = &dir_class_object_handlers;
+
+	memcpy(&dir_class_object_handlers, &std_object_handlers, sizeof(zend_object_handlers));
+	dir_class_object_handlers.get_constructor = dir_class_get_constructor;
+	dir_class_object_handlers.clone_obj = NULL;
+	dir_class_object_handlers.compare = zend_objects_not_comparable;
 
 #ifdef ZTS
 	ts_allocate_id(&dir_globals_id, sizeof(php_dir_globals), NULL, NULL);

ext/standard/dir.stub.php

@@ -87,7 +87,11 @@
  */
 const SCANDIR_SORT_NONE = UNKNOWN;
 
-class Directory
+/**
+ * @strict-properties
+ * @not-serializable
+ */
+final class Directory
 {
     public readonly string $path;
 

ext/standard/dir_arginfo.h

@@ -23,6 +23,4 @@ try {
 
 ?>
 --EXPECT--
-int(17)
-Using original object:
-int(0)
+Error: Trying to clone an uncloneable object of class Directory

ext/standard/tests/directory/DirectoryClass_cannot_clone.phpt

@@ -12,9 +12,4 @@ try {
 
 ?>
 --EXPECT--
-object(Directory)#1 (0) {
-  ["path"]=>
-  uninitialized(string)
-  ["handle"]=>
-  uninitialized(mixed)
-}
+Error: Cannot directly construct Directory, use dir() instead

ext/standard/tests/directory/DirectoryClass_cannot_construct.phpt

@@ -12,5 +12,5 @@ try {
 }
 
 ?>
---EXPECTF--
-string(%d) "O:9:"Directory":2:{s:4:"path";s:%d:"%s";s:6:"handle";i:%d;}"
+--EXPECT--
+Exception: Serialization of 'Directory' is not allowed

ext/standard/tests/directory/DirectoryClass_cannot_serialize.phpt

@@ -14,7 +14,7 @@ echo $rc;
 ?>
 --EXPECTF--
 Structure of Directory class:
-Class [ <internal%s> class Directory ] {
+Class [ <internal%s> final class Directory ] {
 
   - Constants [0] {
   }